Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore(jscs): update jscs and update deprecated rules #9616

Closed
wants to merge 2 commits into from
Closed

chore(jscs): update jscs and update deprecated rules #9616

wants to merge 2 commits into from

Conversation

hzoo
Copy link
Contributor

@hzoo hzoo commented Oct 14, 2014

Updated grunt-jscs and deprecated rules:
requireLeftStickedOperators and requireRightStickedOperators.

Fixes #9429

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

hzoo added 2 commits October 14, 2014 17:07
Updated grunt-jscs and deprecated rules:
requireLeftStickedOperators and requireRightStickedOperators.

Fixes #9429
@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@hzoo
Copy link
Contributor Author

hzoo commented Oct 16, 2014

I can also go ahead and add more rules from .jscs.json.todo and associated changes files in this or separate PR

@IgorMinar IgorMinar closed this in d7f84e2 Oct 17, 2014
IgorMinar pushed a commit that referenced this pull request Oct 17, 2014
@IgorMinar
Copy link
Contributor

@eltacodeldiablo thanks! this is great. if you'd like to work on more todo items then go ahead, but please send one PR per rule so that it's easy to review and quickly get it. Ideally aim for only one pending PR at a time. These style changes affect many files and if the PR gets stale, it's difficult to merge.

cc: @caitp or @petebacondarwin on the PRs so that we can get quickly in before they get stale.

@hzoo hzoo deleted the update-jscs branch October 17, 2014 18:41
@hzoo
Copy link
Contributor Author

hzoo commented Oct 17, 2014

Ok sounds good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jscs update: requireLeftStickedOperators no longer supported
3 participants